[Webkit-unassigned] [Bug 27759] [V8] DOMData needs AtomicallyInitializedStatic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27759


anton muhin <antonm at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antonm at chromium.org




--- Comment #3 from anton muhin <antonm at chromium.org>  2009-07-29 09:31:57 PDT ---
(In reply to comment #2)
> This one too:
> 
> > Index: WebCore/bindings/v8/DOMData.h
> > +WTF::Mutex& DOMDataStore::allStoresMutex()
> > +{
> > +    DEFINE_STATIC_LOCAL(WTF::Mutex, staticDOMDataListMutex, ());
> 
> This looks like it has race conditions.  Please add a comment about why it
> isn't or consider switching to using AtomicallyInitializedStatic (from
> wtf/Threading.h).

Just a minor comment.  If I did measurements right, AtomicallyInitializedStatic
is rather expensive on Windows, so, please, be careful to measure performance
implications.  Maybe sometimes it's easier to have plain static at least for
main thread.

just my 2 cents.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.