[Webkit-unassigned] [Bug 27792] [GTK] new-window-policy-decision-requested provides no information about the target frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27792


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org,
                   |                            |jmalonzo at gmail.com,
                   |                            |xan.lopez at gmail.com




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2009-07-29 02:43:03 PDT ---
First of all, I guess it's reasonable to add the target frame in the
NavigationAction object (the other possibility without breaking API is the
NetworkRequest, which sounds like a worse place), what do the other reviewers
think?

Second, about the patch, I think the target frame property should be
CONSTRUCT_ONLY, and the set_target_frame function shouldn't be public, since
this information won't change during the life cycle of the navigation action
object.

Other than that this looks reasonable for me. Since it's new API we need the
input of another reviewer to get this in, CCing some :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.