[Webkit-unassigned] [Bug 27785] [V8] Add a way to register V8 extensions for Isolated Worlds only

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27785





--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-07-28 16:28:21 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > +        v8::Persistent<v8::Context> createNewContext(v8::Handle<v8::Object>
> > global, bool isolatedContext);
> > 
> > Adding bools to this function doesn't really scale.  Can we pass in the set of
> > extensions somehow?  You might want a helper function that grabs the proper set
> > of extensions for normal and for isolated worlds.
> 
> Doesn't scale how? Do you foresee many other parameters being added here?

There seems to be room for expansion in the rest of the patch:

+ enum IsolatedContextTag { IsolatedContextOnly };

struct V8ExtensionInfo {
    String scheme;
    bool isolatedContextOnly;
    v8::Extension* extension;
};

What if we want to add extensions only for contexts created with certain
permissions?  etc.

> > Also, there's is no such thing as an "isolated context".  There are isolated
> > worlds, which eventually will hold more than one context each.
> 
> I've been using "isolated context" as a generic term for contexts created by
> either "evaluateInNewContext" or "evaluateInNewWorld". Do you have a suggestion
> for a better term?

evaluateInNewContext will eventually be removed.  We're keeping it around in
case we need to audible back to the old design for some reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.