[Webkit-unassigned] [Bug 27785] [V8] Add a way to register V8 extensions for Isolated Worlds only

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27785


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33678|review?(abarth at webkit.org)  |review-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2009-07-28 15:48:10 PDT ---
(From update of attachment 33678)
+        } else if (it->scheme.length() > 0 && (it->scheme !=
m_frame->loader()->activeDocumentLoader()->url().protocol() || it->scheme !=
m_frame->page()->mainFrame()->loader()->activeDocumentLoader()->url().protocol()))
{

You don't need the "else" here because the "if" clause ends in continue.

+        v8::Persistent<v8::Context> createNewContext(v8::Handle<v8::Object>
global, bool isolatedContext);

Adding bools to this function doesn't really scale.  Can we pass in the set of
extensions somehow?  You might want a helper function that grabs the proper set
of extensions for normal and for isolated worlds.

Also, there's is no such thing as an "isolated context".  There are isolated
worlds, which eventually will hold more than one context each.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.