[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

Tue Jul 28 13:34:34 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=26988

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org

--- Comment #45 from David Levin <levin at chromium.org>  2009-07-28 13:34:32 PDT ---
>Indeed, strange that it was still highlighted. (with no flags)
I did that.

In short: Best to stick with one patch per bug (but when you're starting with
WebKit, it is hard to realize that :) ).

Details:
There are several problems when putting multiple patches in one bug.

One problem is the bugs need to remain open even after one of the patches is
landed.  However, if there is an r+ in an open bug, then the bug shows up in
the "commit queue": 

https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=notregexp&short_desc=%5C%5BS60%5C%5D&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%2B&field0-1-0=noop&type0-1-0=equals&value0-1-0=

So it looks like the bug needs to have a patch committed (but it doesn't).  To
solve this, the r+ is cleared for landed patches in open bugs to remove it from
the commit queue. There are mixed opinions on whether the patch should be
marked obsolete.  I didn't because the patch was fine.  This is what you saw
here :)

btw, another problem with multiple patches per bug is trying to figure out what
comments apply to what patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.