[Webkit-unassigned] [Bug 27756] [HTML5][Forms] Support for HTMLInputElement::list and HTMLInputElement::selectedOption

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27756


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33604|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-07-28 10:46:28 PDT ---
(From update of attachment 33604)
Normally we don't commit commented-out code:
 1738     //case DATETIME:
 1739     //case DATE:
 1740     //case MONTH:
 1741     //case WEEK:
 1742     //case TIME:
 1743     //case DATETIMELOCAL:

Why does this need to be PassRefPtr?
 1727 PassRefPtr<HTMLElement> HTMLInputElement::list()
your'e not returning a newly allocated list.

This is very very bad:
 1751             return static_cast<HTMLElement*>(element.get());
That would normally crash.  Grabbing a pointer out of a RefPtr and returning it
is not ok. :(  .release() is what you wanted there.  But again, I don't think
we need this to be a PassRefPtr, or?

Also probably doesn't need to be PassRefPtr:
 1770 PassRefPtr<HTMLOptionElement> HTMLInputElement::selectedOption()

WK style violation:
         if (element && element->isHTMLElement() &&
element->hasTagName(datalistTag)) {
 1751             return static_cast<HTMLElement*>(element.get());
 1752         }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.