[Webkit-unassigned] [Bug 27762] [v8] Cache atomic strings in externalized v8 strings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27762





--- Comment #5 from anton muhin <antonm at chromium.org>  2009-07-28 07:13:25 PDT ---
(In reply to comment #4)
> > 1) Looks like you don't use HintAtomic and there is no support for it in
> > codegen.  Maybe this change should be just postponed?
> 
> I don't use HintAtomic value but I do use the presence/absence of a V8Custom
> annotation in line 1574.
> 
> > 2) do we need to store String now?  String(StringImpl*) ctor seems very cheap. 
> > Maybe only store AtomicString even for String (it might though perform a find
> > on creation, but it might benefit us later as most of DOM api uses
> > AtomicStrings anyway)?
> 
> The reason for the m_impl field is to make sure the String value is kept alive
> even after it has been converted to an AtomicString.  V8 may use the buffer
> underlying m_impl even after m_atomic_impl has been set so both have to be kept
> alive.

AtomicString has String m_string field, cannot we reuse that instead?

> 
> > 3) Safari has a nice optimization that if we don't find AtmoicString, we're
> > guaranteed not to get node by the given idea for example.  Is it possible to
> > incorporate it into Chrome as well?  Of course, not for this CL.
> 
> Good point, we should definitely do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.