[Webkit-unassigned] [Bug 27763] PopupMenuQt lacks proper separator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27763


Adam Treat <treat at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33622|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Treat <treat at kde.org>  2009-07-28 07:09:35 PDT ---
(From update of attachment 33622)
>          if (client()->itemIsSeparator(i)) {
> -            //FIXME: better seperator item
> -            m_popup->insertItem(i, QString::fromLatin1("---"));
> +            m_popup->insertSeparator(i);
>          } else {

Looks like you can remove the braces now from the if clause.  cpplint didn't
catch it?  Also, you can go ahead and remove the #if 0 code.  If it is
important somehow, that's what we have revision control systems for :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.