[Webkit-unassigned] [Bug 27762] [v8] Cache atomic strings in externalized v8 strings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 06:56:13 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27762





--- Comment #3 from anton muhin <antonm at chromium.org>  2009-07-28 06:56:12 PDT ---
Just a minor comments/questions.

1) Looks like you don't use HintAtomic and there is no support for it in
codegen.  Maybe this change should be just postponed?

2) do we need to store String now?  String(StringImpl*) ctor seems very cheap. 
Maybe only store AtomicString even for String (it might though perform a find
on creation, but it might benefit us later as most of DOM api uses
AtomicStrings anyway)?

3) Safari has a nice optimization that if we don't find AtmoicString, we're
guaranteed not to get node by the given idea for example.  Is it possible to
incorporate it into Chrome as well?  Of course, not for this CL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list