[Webkit-unassigned] [Bug 27706] WebCore NPAPI implementations should share more code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27706


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33540|                            |review?
               Flag|                            |




--- Comment #6 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-27 06:27:19 PDT ---
Created an attachment (id=33540)
 --> (https://bugs.webkit.org/attachment.cgi?id=33540)
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>

Reviewed by NOBODY (OOPS!).

Refactor the common parts out of PluginView::init() and add platformInit()

https://bugs.webkit.org/show_bug.cgi?id=27706

PluginViewMac used to call stop() in some cases, but this error handling
should be unified across the different implementations, so removing for now.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

* plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformInit):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 8 files changed, 71 insertions(+), 100 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.