[Webkit-unassigned] [Bug 27706] WebCore NPAPI implementations should share more code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27706


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33538|                            |review?
               Flag|                            |




--- Comment #4 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-27 06:17:08 PDT ---
Created an attachment (id=33538)
 --> (https://bugs.webkit.org/attachment.cgi?id=33538)
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>

Reviewed by NOBODY (OOPS!).

Join the various PluginView destructors into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

- The Mac port does not set m_window to 0 anymore.

- The Qt port used to delete the platform plugin widget as
the last step. Now this is done before cleaning up the
script objects and unloading the plugin package (like
the Win port).

* plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView):
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformInit):
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformInit):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::init):
---
 7 files changed, 59 insertions(+), 74 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.