[Webkit-unassigned] [Bug 27706] WebCore NPAPI implementations should share more code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27706


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33536|                            |review?
               Flag|                            |




--- Comment #2 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-27 06:16:32 PDT ---
Created an attachment (id=33536)
 --> (https://bugs.webkit.org/attachment.cgi?id=33536)
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>

Reviewed by NOBODY (OOPS!).

Join the various versions of PluginView::stop() into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

Differences to the original implementation are as follows:

- The Qt port unregistered the plugin before calling NP_SetWindow
with a 0 window handle. Now it's done after (similar to Win)

- The GTK and Qt ports unregistered the plugin before clearing
the m_npWindow.ws_info struct. Now it's done after.

- The Win port constructed the DropAllLocks after unsubclassing
the window. Now it's done before.

- The Mac, Qt, and GTK ports did not pass a NPSavedData struct
to NP_Destroy (like the Win port). Now all ports do.

- The Win port did not call PluginView::setCurrentPluginView()
before calling to NP-functions. Now it does.

* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::stop):
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::getValueStatic):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
---
 7 files changed, 110 insertions(+), 181 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.