[Webkit-unassigned] [Bug 27655] [v8] cache v8 strings when converting from webcore string to v8 string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27655





--- Comment #4 from David Levin <levin at chromium.org>  2009-07-27 01:06:45 PDT ---
> I don't know if it's safe to use v8 string from different threads.

I don't know about v8 strings, but StringImpl is certainly not safe for use on
multiple threads.

>  If it's the case, I'd only protect the cache with a mutex. 

That should work for the HashMap (but not the StringImpl in it).

> If it's not, it looks like we need thread locals caches.

You may want to add to WebCore/platform/ThreadGlobalData.h


fyi, I've not had time to look into it, but the function v8ValueToWebCoreString
in V8Binding.cpp has similar concerns due to its use of AtomicString which may
not be used across multiple threads.  (I don't know if this can be used from
workers but if it can be, then it should be fixed as well.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.