[Webkit-unassigned] [Bug 27673] Inspector: Tab Through Attributes When Editing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27673





--- Comment #16 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-07-26 10:34:22 PDT ---
(In reply to comment #11)
> All looks fine except this. I fear this is too fragile. It would be better to
> loop through the next siblings until you found "webkit-html-attribute-value".

Done. Ultimately Element Attributes should become more like CSS Properties in
the StylesSidebar.  Right now the attributes are generated HTML and I am forced
to use DOM Traversal functions.  In the StylesSidebar they are actual
TreeElements and I can work on a higher level.

> This would be safer as "elem.hasStyleClass("name")" so if we add more to the
> className later it still works.

No Longer Needed (see next).

> Over all these patches look good, but I think they are too low level and
> fragile at this point. They are working with the DOM too much when they should
> just be working with the high-level TreeElements and TreeOutlines.

Done. Once I understood the structure of the higher-level nodes it became much
easier (TreeOutline, Pane, TreeSection, TreeElement).(In reply to comment #13)

> This should be done without a fake event by asking the ElementsTreeElement to
> start editing on a specific attribute's value or name.

Done. The only remaining fake-event is with Element Attributes of which I
cannot find a workaround for until its refactored.

---

There are a lot of edge cases in ElementAttributes due to the fact that it is
just loosely floating HTML.  And there are even some edge cases in CSS
Properties (such as editing an attribute and then pushing tab silently wipes
things!).  I believe I handle everything correctly and I've tested quite a bit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.