[Webkit-unassigned] [Bug 27488] SVG and XPath memory leaks in V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27488





--- Comment #10 from Mads Ager <ager at chromium.org>  2009-07-24 02:30:30 PDT ---
(In reply to comment #8)
> (From update of attachment 33327 [details])
> This is looking good.  A couple questions:
> 
>          if ($attrIsPodType) {
> -            $resultObject = "wrapper";
> +            $resultObject = "wrapper.get()";
> +        }
> 
> You should just just WTF::getPtr unconditionally.  It should be free in the
> non-RefPtr case.

Thanks.  I'm now including GetPtr.h and using it WTF::getPtr() unconditionally
here.

> -    return V8DOMWrapper::convertNodeToV8Object(object.get());
> +    return V8DOMWrapper::convertNodeToV8Object(object);
> [...]
> -    return V8DOMWrapper::convertNodeToV8Object(object.get());
> +    return V8DOMWrapper::convertNodeToV8Object(object);
> 
> Why no release here?

Because object is a PassRefPtr in these two cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.