[Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=3749


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32823|review?(hyatt at apple.com)    |review-
               Flag|                            |




--- Comment #21 from Dave Hyatt <hyatt at apple.com>  2009-07-23 22:40:10 PDT ---
(From update of attachment 32823)
Why an extra ruby stylesheet?  I think the rules can just go in html.css. 
There are only 4!

ruby { display: inline } is unnecessary.  The default display type is inline,
so you don't need that rule.

Can rp just always be display:none?

When does rt occur outside a ruby?

There is funny indentation in InlineFlowBox.h... it looks like you 3-space
indented instead of 4.

I do not like the addition of an extra virtual function call in
InlineFlowBox.cpp's placeBoxesVertically method.  Possible to avoid it?

In RenderBlock.cpp I worked hard to devirtualize the container walk, so having
it be re-virtualized is bothersome.  I'm curious why that is needed.  It looks
like you're using some CSS style constant to scramble order.  Is that actually
part of HTML5?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.