[Webkit-unassigned] [Bug 27610] Add check for line-breaking rule #3 to cpplint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 15:36:00 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27610


Jakob Petsovits <jpetso at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33379|review?                     |
               Flag|                            |
  Attachment #33379|0                           |1
        is obsolete|                            |
  Attachment #33386|                            |review?
               Flag|                            |




--- Comment #8 from Jakob Petsovits <jpetso at gmx.at>  2009-07-23 15:35:59 PDT ---
Created an attachment (id=33386)
 --> (https://bugs.webkit.org/attachment.cgi?id=33386)
Add check for line-breaking rule #3 to cpplint

Third try. Changes this time:
- Adding goto as fourth exit statement that triggers this check.
- Updating not only the code but also comments to reflect the new situation
with multiple exit statements.
- Make the (otherwise unrelated) label indentation check more permissive,
because currently it doesn't allow for goto labels at the very start of a line.
- Even more unit tests. If I didn't know these are all necessary, I'd say it's
too many of them. But no, these are all necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list