[Webkit-unassigned] [Bug 27400] Inspector: Automatically Refresh DOM Storage Grids on "storage" event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27400





--- Comment #4 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-07-23 14:38:38 PDT ---
(In reply to comment #2)
> You should add your name and copyright on a new line instead.

Done.

> You should use double quotes for strings.

Done. All.

> An early return would be better here.

Done.


> > +            var domStorageLength = this._domStorage.length;
> > +            for (var i = 0; i < domStorageLength; ++i) {
> > +                var domStorage = this._domStorage[i];
> > +                if (flag == domStorage.isLocalStorage) {
> 
> Triple equals.

Done. Renamed flag to "isLocalStorage" like the inspect() patch coming for
Keishi.

> > +                    var view = domStorage._domStorageView;
> > +                    if (this.visibleView && view == this.visibleView)
> 
> Ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.