[Webkit-unassigned] [Bug 27434] adding necessary functions and properties to Document IDL gobject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27434





--- Comment #15 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-23 14:25:12 PDT ---
(In reply to comment #14)
> (From update of attachment 33344 [details])
> I would prefer that we skip generation of Location and Document::location until
> they can be supported properly.  As I noted in a previous comment, the WebKit
> APIs already provide mechanisms for retrieving the URL of a frame so I don't
> buy the argument that this property *needs* to be exposed *now*.

 this is similar to what sam asked, here:
  https://bugs.webkit.org/show_bug.cgi?id=27435#c10

 and, likewise, there are a number of reasons, repeated here.

 out of simplicity, to not massively disrupt the existing test platform - the
_only_ comprehensive test platform, pyjamas-desktop, you don't go ripping
sections of the available test suite out.

 you also don't go making developers' lives more difficult.  if code has
 to be written that doesn't conform to the API, that's more code to maintain.

 yes, it _needs_ to be exposed _now_ because it's being _used_.  _now_.  and
has been for several months.

 this isn't some futuristic API: it's in actual use.

 fortunately, as i mentioned, actual changing of location isn't being used (and
hasn't been asked for) as there is Window.open(.....)

 so - sorry, but utilising some quotes "existing" quotes API that isn't
actually the DOM isn't acceptable.  forcing people to write code that makes
exceptions for webkit, by having a non-standard, non-DOM-based version of the
API is _not_ a good enough reason to turn down a review.

 thus, review- is denied, which leaves me free to re-enable it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.