[Webkit-unassigned] [Bug 27329] Inspector: Properties Should be Sorted more Naturally

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 14:21:39 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27329





--- Comment #18 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-07-23 14:21:39 PDT ---
NOTES:
 - I removed the "==" because no two Object Properties are going to be the
same.

(In reply to comment #15)
> No need for spaces on the inside of the parenthesis.

Done.


> The else should be on on the same line as the curly brace.

Done.


> Maybe move the sort function to Utilities.js so it could be used by other
> callers?

Because this sort is specialized to work on Strings and where no two objects
passed in are going to be equal, I kept this inside ObjectProperties with a
comment on how to make it more generic.  If you'd rather put the generic
version into utilities (performance aside) then let me know.


> I think sorting the completions this way would be good too.

I assume (untested) that a javascript based sort like this would run much
slower then the built-in sort.  Since the auto-completion runs quite often I
decided to keep the completion using the default sort.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list