[Webkit-unassigned] [Bug 27400] Inspector: Automatically Refresh DOM Storage Grids on "storage" event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27400


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32993|review?                     |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-07-23 11:52:34 PDT ---
(From update of attachment 32993)

> - * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007, 2008, 2009 Apple Inc.  All rights reserved.

You should add your name and copyright on a new line instead.

> +        inspectedWindow.addEventListener('storage', this._storageEventListener, true);

You should use double quotes for strings.

> +        var flag = (event.storageArea == InspectorController.inspectedWindow().localStorage);
> +        if (this._domStorage) {

An early return would be better here.

> +            var domStorageLength = this._domStorage.length;
> +            for (var i = 0; i < domStorageLength; ++i) {
> +                var domStorage = this._domStorage[i];
> +                if (flag == domStorage.isLocalStorage) {

Triple equals.

> +                    var view = domStorage._domStorageView;
> +                    if (this.visibleView && view == this.visibleView)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.