[Webkit-unassigned] [Bug 14410] Dragging a resource in the sidebar should drag it's URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14410


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33008|review?                     |review-
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at hatcher.name>  2009-07-23 11:33:31 PDT ---
(From update of attachment 33008)
> +        var link = document.createElement('a');
> +        link.href = this.resource.url;
> +        link.className = 'invisible';
> +        for (var i = 0, len = this._listItemNode.children.length; i < len; ++i)
> +            link.appendChild(this._listItemNode.firstChild);
> +        this._listItemNode.appendChild(link);

This should use childNodes and not children. You could do this another way
using DOMRange's surroundContents() function.

https://developer.mozilla.org/en/DOM:range.surroundContents

Also use double quotes for strings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.