[Webkit-unassigned] [Bug 27541] Web Inspector: Split InspectorController into InspectorController and InspectorBackend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27541





--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2009-07-23 10:45:01 PDT ---
(In reply to comment #5)
> (From update of attachment 33333 [details])
> What cleans up the plain pointer reference the InspectorBackend has to the
> InspectorController? It looks like you want to make InspectorController not be
> RefCounted anymore, but I don't see a change in the class inheritence.
> 
> Basically what guarentees the InspectorBackend has a valid InspectorController
> reference still when InspectorBackend is RefCounted and can be wrapped to
> JavaScript objects that have a GC lifetime?
> 
> Maybe InspectorController needs to stay RefCounted and still have RefPtr on
> Page or when InspectorController goes away it disconnects from
> InspectorBackend.
> 
> Otherwise patch looks great!

InspectorController was meant to stop being ref-counted. I fixed Page's header,
but missed InspectorController's inheritance somehow.

Let me clear InspectorBackend::m_inspectorController in the
InspectorController's destructor to initiate 'disconnect'. I will also add
guards to the places in the code where controller is being accessed via the
backend object. Sounds good?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.