[Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27561





--- Comment #15 from Yong Li <yong.li at torchmobile.com>  2009-07-23 10:42:23 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > Created an attachment (id=33342)
 --> (https://bugs.webkit.org/attachment.cgi?id=33342) [details] [details]
> > decode from stream source data
> 
> It looks like this patch expects the prior patch to already be applied.  Is
> that true?

yes.

> 
> Also it looks like you don't modify BMPImageDecoder, ICOImageDecoder, or
> XBMImageDecoder.  Will that cause problems when you encounter one of these
> image types?

We haven't supported bmp, ico and xbm images yet.

Code blocks under USE(IMAGEFRAMESINK) must be modified to work for other
platforms.

I just found that there are still something there WINCE-specific. For example:

1) always use 16bit for JPEG images
2) use 16bit for those PNG images that don't have alpha channel
3) decode GIF to 32bit first, checking transparent color during decoding. if
the transparent color is unique and it doesn't conflict with other colors after
converting 16bit, then we convert the image buffer from 32bit to 16bit. On
Windows platform, TransparentBlt can paint an image without specified
transparent color used as a mask, which could be cheaper than AlphaBlend.

On other platforms, people may want different behaviors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.