[Webkit-unassigned] [Bug 27488] SVG and XPath memory leaks in V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27488


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33327|review?                     |review-
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2009-07-23 09:13:05 PDT ---
(From update of attachment 33327)
This is looking good.  A couple questions:

         if ($attrIsPodType) {
-            $resultObject = "wrapper";
+            $resultObject = "wrapper.get()";
+        }

You should just just WTF::getPtr unconditionally.  It should be free in the
non-RefPtr case.

-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);
[...]
-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);

Why no release here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.