[Webkit-unassigned] [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27437





--- Comment #9 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-23 06:26:42 PDT ---
(In reply to comment #8)
> (From update of attachment 33192 [details])
> > Index: WebCore/ChangeLog
> > ===================================================================
> > --- WebCore/ChangeLog	(revision 44473)
> > +++ WebCore/ChangeLog	(working copy)
> > @@ -62327,6 +62335,21 @@
> >          (WebCore::PluginPackage::fetchInfo):
> >          (WebCore::PluginPackage::isPluginBlacklisted):
> >  
> > +2008-11-30  lkcl <lkcl at lkcl.net>
> 
> Please put the correct date and your name here.

 ack.

> > +
> > +        Reviewed by NOBODY (OOPS!)
> > +
> > +        https://bugs.webkit.org/show_bug.cgi?id=27437
> > +
> > +		Make width and height attributes DOMString except for
> > +		LANGUAGE_OBJECTIVE_C due to API backwards-compatibility
> > +		reasons.  HTML5 specification has HTMLAppletElement
> > +		and HTMLEmbedElement width and height now marked as a
> > +		DOMString.
> 
> You have a number of tabs here that our pre-commit hook will be unhappy with.

 ah, drat.  didn't know that.  did wonder why stuff was on one line.  duh.

> > +
> > +        * html/HTMLAppletElement.idl: width and height attributes DOMString except for LANGUAGE_OBJECTIVE_C
> > +        * html/HTMLEmbedElement.idl: width and height attributes DOMString except for LANGUAGE_OBJECTIVE_C
> 
> It'd be great if these sentences had correct grammar.

 *chortle* yes it would.

> Please resubmit with an updated ChangeLog so that this can be landed.

 ack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.