[Webkit-unassigned] [Bug 27434] adding necessary functions and properties to Document IDL gobject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27434


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16401




--- Comment #6 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-23 03:23:25 PDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > > @@ -180,7 +181,8 @@
> > >  
> > >          NodeList getElementsByName(in DOMString elementName);
> > >  
> > > -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> > > +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> > > +     (defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
> > >                   attribute [Custom] Location location;
> > >  #endif
> > 
> > This is flagged as being [Custom] but I don't see a gobject method implementing
> > this property anywhere in the patch.  Did you forget to include it?
> 
> Thinking on this further, I suspect Custom may actually mean JSCustom so my
> question may not have been quite right.  The WebCore::Location object itself
> does not have any mutable members, while the IDL specifies that the properties
> are mutable.  The JavaScript bindings have custom logic for Location so that
> manipulating its properties results in the expected navigations.  Without this
> custom logic it's not clear to me how the bindings for Location will compile,
> and thus why it is useful to expose this particular attribute.

 ohhh, i see.  hah.  right.  that helps to know that there will be extra
 work required to make that happen at some point.

 context: the pyjamas API provides access to location because that's
 what GWT does.  the functions provided _mostly_ comprise "decoding"
 of location (reading from it).

 however, for personal projects that utilise the pyjamas API, i never
 used _setting_ of location, i always utilised Window.open().  that's
 not to say that someone else might try to use them and get unexpected
 results, so i will submit a patch which makes them read-only for now.

 thanks for noting this, mark.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.