[Webkit-unassigned] [Bug 27434] adding necessary functions and properties to Document IDL gobject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27434


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33063|review?                     |review-
               Flag|                            |




--- Comment #3 from Mark Rowe (bdash) <mrowe at apple.com>  2009-07-23 00:56:27 PDT ---
(From update of attachment 33063)
> Index: WebCore/dom/Document.idl
> ===================================================================
> --- WebCore/dom/Document.idl	(revision 44473)
> +++ WebCore/dom/Document.idl	(working copy)
> @@ -154,7 +154,8 @@
>  
>                   attribute [ConvertNullToNullString] DOMString title;
>          readonly attribute DOMString referrer;
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +     (defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>                   attribute [ConvertNullToNullString] DOMString domain;
>  #else
>          readonly attribute DOMString domain;

I wonder why the non-JavaScript case is marked as readonly. The HTML 5 spec
suggests it should not be.  It may be that we should consider removing the
#if's here.

> @@ -180,7 +181,8 @@
>  
>          NodeList getElementsByName(in DOMString elementName);
>  
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +     (defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>                   attribute [Custom] Location location;
>  #endif

This is flagged as being [Custom] but I don't see a gobject method implementing
this property anywhere in the patch.  Did you forget to include it?

> @@ -193,7 +195,8 @@
>          Element            elementFromPoint(in long x, in long y);
>  
>          // Mozilla extensions
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +     (defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>          DOMSelection       getSelection();
>  #endif

The #if's should probably be removed from this one.  The method was added in
<http://trac.webkit.org/changeset/30515>, where the ChangeLog notes that it was
restricted to JS as it was only added for web compatibility.  Since then, the
getSelection attribute on Document has made its way in to the HTML 5
specification:
<http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#documents>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.