[Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27561





--- Comment #10 from Yong Li <yong.li at torchmobile.com>  2009-07-22 15:17:24 PDT ---
(In reply to comment #9)
> OK... that's not at all what I meant about breaking things into pieces.  Those
> patches are physically separate, but logically intertwined.  I meant to break
> things into patches where each patch added exactly one capability.
> 
> I think doing that would help address all the concerns above, e.g. make it
> easier to see how other ports would be affected, and make it easier to test if
> something decreased execution speed.
> 
OK, I will sort it out.

> Overall I'm not worried about decreasing speed by cleaning things up; for
> example, replacing the gotos with calls to a small non-virtual helper function
> in the same file will not hurt.

If ImageFrameSink and "segmented" SharedBuffer are accepted for all platforms,
then the code can be easier to simplify. I hate those #if ..., too.

Without "segmented" SharedBuffer, a 4MB image file must be stored in a 4MB flat
memory block as encoded image data. Also, the buffer will be resized many times
when ResourceHandle keeps adding new data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.