[Webkit-unassigned] [Bug 27567] New: False positives in namespace indentation checks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 15:00:22 PDT 2009


           Summary: False positives in namespace indentation checks
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jpetso at gmx.at

Yong Li discovered a false positive for the namespace indentation check in
implementation files, triggered by this piece of code:

namespace WebCore {

    : hMenu(::CreatePopupMenu())
    , itemCount(0)

It turns out that the regular expression skipping goto labels was too
permissive, and thus treated the line with the constructor's signature as
label, skipping it and (then correctly) causing the error for the indented
second line. Not cool, sorry for that bug.

This patch improves on the concerned code, makes the unit tests more demanding,
and fixes the bug. Please review!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list