[Webkit-unassigned] [Bug 27544] cpplint generates false positives for primary includes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27544


Jakob Petsovits <jpetso at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33264|0                           |1
        is obsolete|                            |
  Attachment #33272|                            |review?
               Flag|                            |




--- Comment #3 from Jakob Petsovits <jpetso at gmx.at>  2009-07-22 11:10:26 PDT ---
Created an attachment (id=33272)
 --> (https://bugs.webkit.org/attachment.cgi?id=33272)
Fix cpplint generating false positives for primary includes (try 2)

Combined the two ifs into one condition in this new patch. This also makes it
apparent that there is no need to make the check stricter than startswith()
after encountering the first occurrence, because it won't be triggered anyways.

> (regarding header_types dict)
> Ahh, now I see.  Perhaps is ok, but not strictly necessary for this patch.

It was actually necessary, because the second _classify_include() apparently
caused some state change which in turn caused some test case to fail. So this
change makes the first _classify_include() to be the only one that's being
called, which ensures proper state tracking.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.