[Webkit-unassigned] [Bug 27512] Test for QWebFrame::hasSetFocus() is trying to use a not defined resource.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 11:06:42 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27512





--- Comment #4 from Andre Pedralho <apedralho at gmail.com>  2009-07-22 11:06:42 PDT ---
(In reply to comment #3)
> (From update of attachment 33207 [details])
> As tonikitoo pointed out, we shouldn't dupe the resources, but rather share
> them.

Agree with that, however "the listed resource files must be located in the same
directory as the .qrc file, or one of its subdirectories" according to the Qt 
resources docs.

As there are two different directories to QWebFrame and to QWebPage tests the
only way to share the resources would be to have a pool of resources in
WebKit/qt/tests/'resources'/ with the qrc files related to both tests.

I mean:

ls WebKit/qt/tests/:
benchmarks  qwebelement  qwebframe (...) qwebpage  qwebview  RESOURCES
tests.pro

ls WebKit/qt/tests/resources:
FRAMETEST image.png qwebframe.qrc style.css tst_qwebpage.qrc

IMHO, the best solution here is to create separated resources to each tests,
maybe duplicating it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list