[Webkit-unassigned] [Bug 27544] New: cpplint generates false positives for primary includes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27544

           Summary: cpplint generates false positives for primary includes
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jpetso at gmx.at


The test for primary includes is intentionally broad in order to catch
platform-specific variations (e.g. "BlahQt.h", "BlahWince.h", etc.). However,
that might lead to a situation where an include file is classified as primary
include even though it's not. The patch below avoids this situation for code
where cpplint would detect multiple primary includes - obviously, only one can
be the real thing, which is (hopefully) the first one.

By introducing a bit more state into the _IncludeState class, subsequent
"primary" includes after the actual (first) one can be treated as regular
"other" includes, fixing the false positive. See the test case for a less
abstract example of this situation.

Brought to attention by Yong Li.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.