[Webkit-unassigned] [Bug 27524] Add check for correct wtf includes in WebCore to cpplint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27524


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33225|review?                     |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-07-21 16:47:31 PDT ---
(From update of attachment 33225)
> diff --git a/WebKitTools/Scripts/modules/cpplint.py b/WebKitTools/Scripts/modules/cpplint.py
> +        # Check specific include file rules.
> +        if filename != "-":

When is the filename "-" ?

> +            filepath = os.path.abspath(filename)
> +            filepath_parts = filepath.split(os.sep)
> +            if 'WebCore' in filepath_parts:

Why only WebCore? I think this is true in all directories. (And if it should
only be WebCore, please add a test for this.)



>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.