[Webkit-unassigned] [Bug 27436] gobject bindings need access to keyCode on KeyboardEvents!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 11:34:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27436





--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-21 11:34:20 PDT ---
ah... looking at this a little closer, i believe that the reason why
i commented out the initKeyboardEvent function on GOBJECT bindings
would have been because you can't, in c, have two functions with
the same name.

and the gobject bindings auto-generator would have created two
gdom_keyboard_event_init_keyboard_event() functions, because of
the two initKeyboardEvent entries in the IDL file.

so i simply #ifdef'd one of them out.

stupidly, i actually managed to #ifdef out keyCode and charCode
as well!  so, duh, thank you for drawing my attention to this!

anyway - i'll submit a revised patch which has !LANGUAGE_OBJC
around keyCode and charCode.... errr... are you sure?

i'll submit it for your attention, you let me know if it should
be !LANGUAGE_OBJC or !LANGUAGE_JAVASCRIPT ok?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list