[Webkit-unassigned] [Bug 27462] Add cpplint check for proper include order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27462


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33191|review?                     |review+
               Flag|                            |




--- Comment #8 from David Levin <levin at chromium.org>  2009-07-21 11:11:54 PDT ---
(From update of attachment 33191)
Would be nice to make s small adjustment on landing.

> +                if filename.endswith('.h'):
> +                    error(filename, line_number, 'build/include_order', 4,
> +                          '%s Should be: alphabetically sorted.' %
> +                          (error_message))
No need for parens on error_message (since it is a single element).

Btw, wierd python-ism: the parens do nothing here :) 
to make it a tuple with one element you'd have to do this: (error_message,)



> +                else:
> +                    error(filename, line_number, 'build/include_order', 4,
> +                          '%s Should be: config.h, primary header, blank line, and then alphabetically sorted.' %
> +                          (error_message))

Same comment about (error_message)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.