[Webkit-unassigned] [Bug 27416] Windows build break due to warning C4819

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27416


Takeshi Yoshino <tyoshino at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyoshino at google.com




--- Comment #4 from Takeshi Yoshino <tyoshino at google.com>  2009-07-21 10:57:33 PDT ---
(In reply to comment #3)
> I marked the bugs as "dependent" to simply point out to anyone looking at
> either that they're both solving similar issues.  We should solve both issues
> in the same way.

1. All bad characters in MixedMode.h, ConditionalMacros.h are in comments
   and they seem to just get garbled.
2. The only bad character in AssertMacros.h and TargetConditionals.h is the
   copyright symbol (\xA9. In other files "(C)" is used. It is in
   ISO/IEC 8859-1 but not in ASCII) in copyright notice head comment.
3. The only bad character in Multiprocessing.h is also the copyright symbol
   \xA9. Only this character is non-comment. It's contained in a string
   literal macro MPCopyrightNotice.

So, I think Kwang's proposal will work for 1 and 2. I'm not sure if 3 is
problematic or not.

As I explained in that bug entry (26375) as follows, suppressing warning
cannot be applied to 26375 case.
> Save mode: Unicode (UTF-8 without signature) - Codepage 65001
> The source was encoded by UTF-8 w/o BOM
> Build: Failure. We need to remove /Wx option (take warnings as errors)
> Build w/o /Wx: Successful
> Result: localized string not found

Vice versa, it doesn't make sense to replace copyright marks in comments by
\xA9. Maybe, we should use "(C)". Is it acceptable, Apple guys?

Thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.