[Webkit-unassigned] [Bug 27478] All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27478


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33140|review?                     |review+
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-07-21 10:19:06 PDT ---
(From update of attachment 33140)
This patch is awesome.  Redundant code: BE GONE!

+        I've added two new classes: DOMObjectWithGlobalPointer and
DOMConstructorObjectInDocument.

The ChangeLog uses the old class names.

+    class DOMConstructorWithDocument : public DOMConstructorObject {
+    public:
+        Document* document() const
+        {
+            return static_cast<Document*>(scriptExecutionContext());
+        }
+    protected:

Missing a blank line here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.