[Webkit-unassigned] [Bug 26316] 100% CPU hang for several seconds on large file syntax highlight.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26316





--- Comment #19 from Keishi Hattori <casey.hattori at gmail.com>  2009-07-21 09:09:43 PDT ---
(In reply to comment #18)
> arghh.  I've added a pointer to this bug in Bug 26272 (a bug I opened asking
> for the .js files to stop getting bundled in the build).

We don't bundle for debug builds so I feel this is OK (if there really is a
noticeable speed difference in bundling). I think creating a subdirectory for
worker scripts is a good solution.

> It appears you are sending each line over to the worker to be processed.  I
> suspect, especially for large files, that if this was chunked so you sent 100
> or so lines at a time, you'd see some performance improvements.  Assuming the
> worker messaging overhead is somewhat significant.

I suspect there is some message overhead but that doesn't explain why a few
long lines has a larger performance deterioration(relative to the non-worker
version) than a lot of short lines. Strange...

This is going to be a half baked solution anyway. 

The ultimate solution is doing it in JSC.  We need to modify the Lexer so it
handles the white spaces.
And drastically modify HTMLViewSourceDocument which is closely tied to the
HTMLTokenizer.

I was curious as to how far we can push this but I think I've put enough effort
into the JS solution and I'm better off working on the C++ solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.