[Webkit-unassigned] [Bug 27483] diff_parser should accept lines without trailing \n

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27483


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33145|review?                     |review+
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-07-20 23:50:07 PDT ---
(From update of attachment 33145)
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog

> +
> +        Normalize the input lines by removing a trailing newline.
> +        Also, add a case for unittest for newly added files.
I think this reads better: "Also, add a case to the unittest for newly added
files."

fwiw, it is best to keep your patches focused on one thing and this does a bit
more, so the bug doesn't reflect what is being done. However, it is all rather
simple and you do describe it, so no need to break it up this time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.