[Webkit-unassigned] [Bug 27444] Wrong FrameLoader::activeDocumentLoader when loading an invalid URL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27444





--- Comment #6 from Antonio Gomes (tonikitoo) <tonikitoo at gmail.com>  2009-07-20 19:03:15 PDT ---
thanks again for the comments , brady.

> the Mac bots are all running green right now, I assume you mean there's a Qt
> failure that this cleans up.  But have you tried running the Mac tests with
> your patch in?

I will try it at work tomorrow and report the results.

> I don't know - Do you have a Mac machine to try with your patch? 
> It's quite possible there isn't, as one thing I know this patch breaks - which
> is the WebKit API [WebDataSource unreachableURL] - has historically been
> difficult to test automatically.
> 
> If your patch *doesn't* break any Mac layout tests, then we need to take the
> time to add one.

that specific test would be definitively a great and needed add. So if no
failure are catch on Mac when i re-run the tests, should I file a bug on adding
that test ?

> > so how do access the documentLoader that actually refers to the latest load
> > (being in successful or not) ?
> 
> I followed your description here and looked at the other bug.  Amusingly, the
> main thing this patch would break is what happens in the error case, which
> covered by DocumentLoader::unreachableURL().

iirc, m_unreachebleURL will get set at object construction time. However I can
not rely on it from qtwebkit api code, I am afraid.

> When you say "latest load", you are overloading some highly overloaded
> terminology.  In FrameLoader/DocumentLoader-land, the "current load" is the
> most recent main resource load to have been committed.  When a load fails
> because the url wasn't even valid, it was never committed, so the current
> activeDocumentLoader() remains unchanged.

sorry for mis-using the term ... i see and agree w/ what you pointed out,
although i still think having access to the unsuccessful resource loader could
be helpful. What do you think ?

> Alas, information about this attempted-load-not-even-getting-started is tacked
> on the DocumentLoader.  Based on reading the other bug, you are happy with
> url() and originalURL(), but just want to know about failure cases.  

exactly that.

> What happens if you try using activeDocumentLoader()->mainDocumentError()?

as you said, I could use that *if* activeDocumentLoader() returns the resource
loader corresponding to the failing loader. I will check ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.