[Webkit-unassigned] [Bug 27444] Wrong FrameLoader::activeDocumentLoader when loading an invalid URL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27444





--- Comment #3 from Antonio Gomes (tonikitoo) <tonikitoo at gmail.com>  2009-07-20 13:54:58 PDT ---
> Thanks for your interest and thanks for you patch, but I think you're chasing
> down a non-issue.

thanks for the comments.

> Most importantly, a Frame shouldn't ever consider a failed, non-committed load
> as it's current DocumentLoader.  Making this change would be a change in
> behavior that many WebKit applications do not expect. Most notably, Safari
> would break with this change.

is there any regression test for it ?

> Can you explain an example of an application you're working on where this
> change is desirable?  And why?

I should had mentioned it before, yes. I am working on
https://bugs.webkit.org/show_bug.cgi?id=25867 (see patch 0.4) , which provides
the url originally loaded by the frame.

in case of load failures, frameLoader->activeDocumentLoader points to a
documentLoader instance of a (successful) previous load (see bug description).
In this case, if i 

1) load google.com
2) load a known unexistent url
3) call originalUrl()
4) it calls FrameLoader::originalRequest() , which calls
activeDocumentLoader()->originalRequest.url() => http://google.com

since activeDocumentLoader is not referring to the latest load but to the
latest successful one.

so how do access the documentLoader that actually refers to the latest load
(being in successful or not) ?

> Also, if a layout test times out with your patch in but runs correctly without
> your patch, that *is* indicative of a regression with your patch.  I bet the
> test is catching exactly the WebKit API breakage that I alluded to.

i mis-explained maybe, but there is one less failing test w/ the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.