[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988





--- Comment #35 from Ryan Leavengood <leavengood at gmail.com>  2009-07-20 13:19:57 PDT ---
(In reply to comment #34)
> 
> This is a new style that WebKit is moving to that likely post dates the other
> implementations, so that's why they use an enum.
> 
> For example see https://bugs.webkit.org/show_bug.cgi?id=26695, where this was
> said when someone was adding a new bool parameter:
>   We're trying to avoid adding boolean parameters, because they are not very
>   clear (when reading code like "hitTestResultAtPoint(point, true, false,
> true)",
>   what do the booleans mean?). One strategy to replace a boolean parameter is
> to
>   use a two-value enum, like this:
> 
>   enum HitTestScrollbars { ShouldHitTestScrollbars, DontHitTestScrollbars };

For what it is worth, I agree with David on this. It definitely makes sense and
since we are a new port, let's move in a better direction, especially if the
rest of WebKit is going that way.

Let's also maybe keep it in mind for the browser code too.

Regards,
Ryan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.