[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988





--- Comment #33 from Maxime Simon <simon.maxime at gmail.com>  2009-07-20 10:37:01 PDT ---
(In reply to comment #31)
> > +ClipboardHaiku::ClipboardHaiku(ClipboardAccessPolicy policy, bool forDragging) 
> > +    : Clipboard(policy, forDragging)
> > +{
> > +}
> > +
> > +void ClipboardHaiku::clearData(const String& type)
> > +{
> > +    BMessage *data = (BMessage *) NULL;
> 1. Star in wrong place.
> BMessage* data
> 
> 2. Use c++ style casts. (BMessage *)  (but I don't think the cast is necessary.
> 
> 3. Use 0 instead of NULL.

Strange, I thought I corrected these style problems.
Anyway, it's done in the new patch. :)


> > diff --git a/WebCore/platform/haiku/ClipboardHaiku.h b/WebCore/platform/haiku/ClipboardHaiku.h
> > +    // State available during IE's events for drag and drop and copy/paste
> > +    class ClipboardHaiku : public Clipboard {
> > +    public:
> > +        ClipboardHaiku(ClipboardAccessPolicy policy, bool forDragging);
> 
> "bool forDragging"
> Please use an enum instead of a bool. (See
> http://trac.webkit.org/browser/trunk/WebCore/workers/WorkerScriptLoader.h for
> an example of where this was done.)

On this point I don't really agree. I know what you mean but, as I looked in
other ports,
none of them used an enum but a boolean.
However, I corrected something in ClipboardHaiku.h: other ports designed this
class
with the constructor as private and have a static method to create the
clipboard. So did I.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.