[Webkit-unassigned] [Bug 27349] [WINCE] Add GraphicsContextWince implementation for WinCE.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 07:12:07 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27349





--- Comment #12 from Yong Li <yong.li at torchmobile.com>  2009-07-20 07:12:06 PDT ---
(In reply to comment #11)
> (In reply to comment #8)
> > Oops: lround does different thing:
> > 
> > inline long lround(double num) { return static_cast<long>(num > 0 ? num + 0.5 :
> > ceil(num - 0.5)); }
> > 
> > What we want in GraphicsContextWince.cpp is to round -0.5 to 0, as 0.5 is
> > rounded to 1, so that the rendering behavior is consistent when offset varies.
> > 
> > but lround(-0.5) will return -1.
> 
> In that case I'd recommend giving your function a different name, so that its
> difference in behavior from the standard functions will be more clear.

yes. I'm going to change it to safeRound() or something else

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list