[Webkit-unassigned] [Bug 27372] [v8] switch to faster methods to obtain and set implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27372





--- Comment #5 from anton muhin <antonm at chromium.org>  2009-07-20 04:30:25 PDT ---
(In reply to comment #3)
> (From update of attachment 32942 [details])
> Thanks for the patch.  This looks great.  One question, how do we know this is
> safe:
> 
> +        node =
> V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(args[0]));
> 
> or
> 
> +        contextNode =
> V8DOMWrapper::convertDOMWrapperToNode<Node>(v8::Handle<v8::Object>::Cast(args[1]));
> 
> Why can't the page pass a value as the argument?

Adam, could you double check, but we did this cast unconditionally in
DOMWrapper::convertToNativeObject anyway.  I just moved cast into callers, not
callee not to penalize callers which already have an object

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.