[Webkit-unassigned] [Bug 17154] [GTK] Widget size negotiation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17154





--- Comment #8 from Holger Freyther <zecke at selfish.org>  2009-07-19 23:03:37 PDT ---
(From update of attachment 33045)

> +    // We need to queue a resize request only if the size changed,
> +    // otherwise we get into an infinite loop!
> +    GtkWidget* widget = GTK_WIDGET(m_webView);
> +    if (GTK_WIDGET_REALIZED(widget) &&
> +        (widget->requisition.height != size.height()) &&
> +        (widget->requisition.width != size.width()))
> +        gtk_widget_queue_resize(widget);

cool, do we need to force a redraw here too? otherwise you could add no_redraw
to it.


> +static void webkit_web_view_size_request(GtkWidget* widget, GtkRequisition* requisition)
> +{
> +    WebKitWebView* web_view = WEBKIT_WEB_VIEW(widget);
> +    Frame* coreFrame = core(webkit_web_view_get_main_frame(web_view));
> +    if (!coreFrame)
> +        return;
> +
> +    FrameView* view = coreFrame->view();
> +    requisition->width = view->contentsWidth();
> +    requisition->height = view->contentsHeight();

I think you should check for the "view" as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.