[Webkit-unassigned] [Bug 27410] [Gtk] adding GObject Language bindings auto-generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27410


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33038|review?                     |review-
               Flag|                            |




--- Comment #17 from Mark Rowe (bdash) <mrowe at apple.com>  2009-07-19 19:31:59 PDT ---
(From update of attachment 33038)
> +package CodeGeneratorGObject;
> +
> +require "CodeGeneratorGObjectLibrary1.pm";

This file doesn't exist as far as I can see.  What is it?  Why is it named in
this manner?

> +
> +# Params: 'domClass' struct

What is this comment about?  The "Params" suggests it is about the arguments to
the following function, but the function appears to take three arguments that
have no relation to this comment.

> +sub GenerateInterface {
> +    my $object = shift;
> +    my $dataNode = shift;
> +    my $defines = shift;
> +
> +    my $name = $dataNode->name;
> +
> +    print "$name\n";

What's the purpose of this print statement?

> +
> +    $object->Generate($dataNode);
> +
> +    # Write changes
> +    my $fname = "Gdom_" . $name; #decamelize($name);

The comment here doesn't seem to add anything.  Why is there commented-out code
here?

> +    $fname =~ s/_//g;
> +    $object->WriteData($fname);
> +}
> +
> +# Params: 'idlDocument' struct

Same comment as for the previous function applies to this comment.

Marking as r- due to these issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.