[Webkit-unassigned] [Bug 27158] Add WebKit version API to Qt.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27158





--- Comment #20 from Simon Hausmann <hausmann at webkit.org>  2009-07-19 15:54:14 PDT ---
(In reply to comment #17)
> Generating a version header file from the Version.xcconfig at build time would
> avoid the need for this individual effort, and would avoid the need for any
> additional manual intervention for version tracking. It would also mean that
> the webkit version in the UA string would always mean the same thing for all
> webkit ports.
> 
> Additionally, nothing fancy should be required to generate the header file in
> other ports build systems, since it can just be added to the same list of calls
> currently generating source from *.idl files at build.

That is a very good point actually :)

> NP. Will await a final direction on whether to go with the manual or
> auto-generated WebKitVersion.h before submitting the first one. Also, can you
> confirm that the root of WebKit/ is the right place to put it?

You're actually right with regards to auto-generation. Generating the header at
build time is not as fancy as I thought. Ok, let's with your approach in
attachment 3 (to generate the header into the generated sources directory).

In addition to Kenneth's comment about the header guards (small nitpick) the
only other thing I can think of right now is to include config.h as first
header file in qwebkitversion.cpp, followed by "qwebkitversion.h" and the
generated header.

I'm sorry for the back and forth :(. You've definitely convinced me now about
generating the header at build time (no need to check it in or manually update
it), and it seems you reached that conclusion on IRC, too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.