[Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27428


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33055|                            |review?
               Flag|                            |




--- Comment #1 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-19 14:23:29 PDT ---
Created an attachment (id=33055)
 --> (https://bugs.webkit.org/attachment.cgi?id=33055)
adds GdomDOMObject

the three files added include GdomDOMObject (and its private hidden struct. 
this will in the future be used to store pointers to exceptions which occur
when a c++ DOM object function gets called).

review comments ... i do recall discussion about removing this; i do recall
that adam managed to remove it entirely.  personally, knowing that the work's
required in the future, i don't like hacking stuff out that will make life
easier in the future.

also, this was an area where martin soto helped contribute: the first design
involving GdomDOMObject had a private c++ object that had a virtual pointer
function mirroring the JSBinding "type()" function, in order to determine the
type even when the intermediate object was actually a c-based one.

it turns out that glib / gobject already has something that does that sort of
thing, so the redundant intermediate class was removed.  hurrah.  less code -
everyone's happy.

further modifications in this area it would be a wise move to leave them until
after this series is all in, and leave this bugreport open as an indicator that
further work is needed in this specific area.  in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.